windows: support -dev mode #7534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support running `nomad agent -dev` in Windows, by setting proper network interface. Prior to this change, `nomad` uses `lo` interface but Windows uses "Loopback Pseudo-Interface 1" to refer to loopback device interface: https://github.com/golang/go/blob/go1.14.1/src/net/net_windows_test.go#L304-L318 .
tgross
approved these changes
Mar 30, 2020
| @@ -743,6 +743,11 @@ func newDevModeConfig(devMode, connectMode bool) (*devModeConfig, error) { | |||
| } | |||
|
|
|||
| func (mode *devModeConfig) networkConfig() error { | |||
| if runtime.GOOS == "windows" { | |||
| mode.bindAddr = "127.0.0.1" | |||
| mode.iface = "Loopback Pseudo-Interface 1" | |||
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support running
nomad agent -devin Windows, by setting proper networkinterface.
Prior to this change,
nomaduseslointerface but Windows uses"Loopback Pseudo-Interface 1" to refer to loopback device interface:
https://github.com/golang/go/blob/go1.14.1/src/net/net_windows_test.go#L304-L318
.