Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: correctly handle missing sidecar_service task stanza #7683

Merged
merged 1 commit into from
Apr 10, 2020
Merged

connect: correctly handle missing sidecar_service task stanza #7683

merged 1 commit into from
Apr 10, 2020

Commits on Apr 10, 2020

  1. connect: correctly deal with nil sidecar_service task stanza 

    Before, if the sidecar_service stanza of a connect enabled service
was missing, the job submission would cause a panic in the nomad
agent. Since the panic was happening in the API handler the agent
itself continued running, but this change will the condition more
gracefully.

By fixing the `Copy` method, the API handler now returns the proper
error.

$ nomad job run foo.nomad
Error submitting job: Unexpected response code: 500 (1 error occurred:
	* Task group api validation failed: 2 errors occurred:
	* Missing tasks for task group
	* Task group service validation failed: 1 error occurred:
	* Service[0] count-api validation failed: 1 error occurred:
	* Consul Connect must be native or use a sidecar service
    @shoenig
    shoenig committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    79a5241 View commit details
    Browse the repository at this point in the history