Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: enable configuring sidecar_task.name #7684

Merged
merged 2 commits into from
Apr 10, 2020
Merged

connect: enable configuring sidecar_task.name #7684

merged 2 commits into from
Apr 10, 2020

Commits on Apr 10, 2020

  1. connect: enable configuring sidecar_task.name 

    Before, the submitted jobspec for sidecar_task would pass
through 2 key validation steps - once for the subset specific
to connect sidecar task definitions, and once again for the set
of normal task definition where the task would actually get
unmarshalled.

The valid keys for the normal task definition did not include
"name", which is supposed to be configurable for the sidecar
task. To fix this, just eliminate the double validation step,
and instead pass-in the correct set of keys to validate against
to the one generic task parser.

Fixes #7680
    @shoenig
    shoenig committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    729931a View commit details
    Browse the repository at this point in the history

  2. connect: extract common task keys

    @shoenig
    shoenig committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    0eb2844 View commit details
    Browse the repository at this point in the history