Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

two fixes for inspect on connect proxy #7690

Merged
merged 2 commits into from
Apr 20, 2020
Merged

two fixes for inspect on connect proxy #7690

merged 2 commits into from
Apr 20, 2020

Commits on Apr 13, 2020

  1. jobspec: correctly parse proxy fields from jobspec 

    Before, the proxy stanza did not parse non-object fields
`local_service_port` and `local_service_address` from the
connect `proxy` stanza. This change fixes that.
    @shoenig
    shoenig committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    dc11226 View commit details
    Browse the repository at this point in the history

  2. structs: fix compatibility between api and nomad/structs proxy defini… 

    …tions

The field names within the structs representing the Connect proxy
definition were not the same (nomad/structs/ vs api/), causing the
values to be lost in translation for the 'nomad job inspect' command.

Since the field names already shipped in v0.11.0 we cannot simply
fix the names. Instead, use the json struct tag on the structs/ structs
to remap the name to match the publicly expose api/ package on json
encoding.

This means existing jobs from v0.11.0 will continue to work, and
the JSON API for job submission will remain backwards compatible.
    @shoenig
    shoenig committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    eef81c3 View commit details
    Browse the repository at this point in the history