Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Add global search #7720

Closed
wants to merge 35 commits into from
Closed

UI: Add global search #7720

wants to merge 35 commits into from

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Apr 14, 2020 •
edited

Todo:

  • quick access via /
  • navigate to chosen item
  • filter undesired classes of response (plugins?)
  • customise option-rendering based on type
  • highlight matched prefixes
    • is this useful though, since it’s only prefixes? 🤔
  • refine appearance
    • move placeholder text up
  • check namespace-handling
  • check region-handling
  • fix bug where peeking doesn’t find unfetched records
  • clicking/tabbing into control should not require pressing enter to start search
  • handle failures
    • they’re not really handled but treated as an empty set… should the error be indicated somehow?
  • ensure options hide when field not active
  • escape should blur
  • tabbing off should work
  • scrolling page shouldn’t scroll options!
  • split CSS components
  • hide on mobile?

@backspace backspace self-assigned this Apr 14, 2020
@backspace
Add keyboard shortcut to open search
aa23fe4 
It works, but the test doesn’t, sadly… not sure why but
skipping it for now.
@backspace
Remove debugging code
f6f50be
@backspace
Fix construction of mock search results
0333f60
@backspace
Add navigation on search item selection
7f3b3ff
@backspace
Remove debugging code
72e0d0b
@backspace
Move search width into CSS
634a2a4
@backspace
Update styling
edc4874
@backspace
Add count to results headings
5a26bcc
@backspace
Add preliminary styling of search results
e14b2c2
@backspace
Add explicit selection of desired result types
fa369b3
@backspace
Add humanising of result group names
a748cee
@backspace
Change model-fetching from peek to find
86f747a 
It’s not reliable to assume that the model will already be
present in the store.
@backspace
Add status lights to search results
58f41a5
@backspace
Remove precalculated labels
216ea00 
Since 86f747a, this has been moved to the promise-aware template,
so precalculating it is no longer necessary.
@backspace
Remove need to press enter after clicking control
e3b513c 
This also applies to tabbing.
@backspace
Update appearance of search field
11f603b
@backspace
Add explanation of focus action
2ba6704
@backspace
Add namespace-awareness
e483e13
@backspace
Remove legacy of confusion 😝
a37a503
@backspace
Add region-handling
fcadd4b
@backspace
Remove outdated FIXME
0edaf12 
This was addressed in e483e13.
@backspace backspace mentioned this pull request Jun 16, 2020
Merged
@backspace backspace closed this Jun 16, 2020
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@backspace backspace

Labels
theme/ui type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@backspace