Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver/docker: protect against nil container #7749

Merged
merged 2 commits into from
Apr 20, 2020
Merged

driver/docker: protect against nil container #7749

merged 2 commits into from
Apr 20, 2020

Commits on Apr 19, 2020

  1. driver/docker: protect against nil container

    Protect against a panic when we attempt to start a container with a name
    that conflicts with an existing one.  If the existing one is being
    deleted while nomad first attempts to create the container, the
    createContainer will fail with `container already exists`, but we get
    nil container reference from the `containerByName` lookup, and cause a
    crash.
    
    I'm not certain how we get into the state, except for being very
    unlucky.  I suspect that this case may be the result of a concurrent
    restart or the docker engine API not being fully consistent (e.g. an
    earlier call purged the container, but docker didn't free up resources
    yet to create a new container with the same name immediately yet).
    
    If that's the case, then re-attempting creation will hopefully succeed,
    or we'd at least fail enough times for the alloc to be rescheduled to
    another node.
    Mahmood Ali committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    9db46fd View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. add changelog

    [ci skip]
    Mahmood Ali committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    7f29912 View commit details
    Browse the repository at this point in the history