Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete/create autoscaling policies as job is stopped/started #7772

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

cgbaker
Copy link
Contributor

@cgbaker cgbaker commented Apr 21, 2020

eases burden on external autoscalers by deleting autoscaling policies from their state store table when the job is stopped, reinserting them when the job is started. this means that blocking calls against the scaling policy list and get endpoints will unblock.

resolves #7768

table as job is stopped (and recreated when job is started)
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. The tests helped me understand the change well!

@cgbaker cgbaker merged commit 27af1f2 into master Apr 22, 2020
@cgbaker cgbaker deleted the b-7768-remove-policies-for-stopped-jobs branch April 22, 2020 13:15
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoscaling policies should not be returned for missing jobs
2 participants