-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add workaround to exclude emoji from task escaping #7813
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
export default function escapeTaskName(taskName) { | ||
// Regular expression is taken from here: https://stackoverflow.com/a/20053121 | ||
return taskName.replace(/[^a-zA-Z0-9,._+@%/-]/g, '\\$&'); | ||
return taskName.replace(/[^a-zA-Z0-9,._+@%/-]/gu, '\\$&'); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should emoji be escaped? Maybe it's harmless?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They don’t need to be but I can’t think of a way to exclude them from escaping while still escaping things that should be, at least without something like
emoji-regex
. I do believe it’s harmless to escape them: slightly unsightly, but emoji in task names are surely rare 🤔The current approach to escaping a task name is “escape everything but these known-to-be-safe characters”. My previous implementation used
emoji-regex
to let emoji be treated as known-to-be-safe but it seems maybe overkill when escaping them this way doesn’t add much noise. The Stack Overflow answer that I linked to for the original regular expression has a more naïve suggestion to instead escape every character but that seems hideous to me 😆There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, I agree with you that escaping everything is a nope. Since this is safe I'm happy with it 😄