Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Log streaming bug fix medley #7820

Merged
merged 5 commits into from
Apr 30, 2020
Merged

UI: Log streaming bug fix medley #7820

merged 5 commits into from
Apr 30, 2020

Commits on Apr 30, 2020

  1. Always pass credential in fetch requests, but also treat options reas… 

    …onably

Now options can be provided without also having to remember to pass
credentials. This is convenient for abort controller signals.
    @DingoEatingFuzz
    DingoEatingFuzz committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    6af31fe View commit details
    Browse the repository at this point in the history

  2. Abort log fetch request when failing over from client to server 

    Typically a failover means that the client can't be reached. However, if
the client does eventually return after the timeout period, the log will
stream indefinitely. This fixes that using an API that wasn't broadly
available at the time this was first written.
    @DingoEatingFuzz
    DingoEatingFuzz committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    fab6fcb View commit details
    Browse the repository at this point in the history

  3. Clicking stdout/stderr when already on that tab is now a noop

    @DingoEatingFuzz
    DingoEatingFuzz committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    e186554 View commit details
    Browse the repository at this point in the history

  4. Fix race condition where stdout and stderr requests can cause a no co… 

    …nnection error

This would happen because a no connection error happens after the second request fails, but
that's because it's assumed the second request is to a server node. However, if a user clicks
stderr fast enough, the first and second requests are both to the client node. This changes
the logic to check if the request is to the server before deeming log streaming a total failure.
    @DingoEatingFuzz
    DingoEatingFuzz committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    e5a5fc7 View commit details
    Browse the repository at this point in the history

  5. Make the no connection error on the logs page dismissable

    @DingoEatingFuzz
    DingoEatingFuzz committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    9557475 View commit details
    Browse the repository at this point in the history