csi: read-repair CSI volume claims #7824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `CSIVolumeClaim` fields were added after 0.11.1, so claims made before that may be missing the value. Repair this when we read the volume out of the state store.
The `NodeID` field was added after 0.11.0, so we need to ensure it's been populated during upgrades from 0.11.0.
langmartin
approved these changes
Apr 29, 2020
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 0.11.0 was shipped, in #7782 and we added some fields for
CSIVolumeClaims and to the request body forCSIVolumeClaimRequestfrom the client. But we need to ensure these fields are present in a backwards-compatible way.This changeset performs read-repair on
CSIVolumeClaims and ensures theNodeIDfield is populated on claim requests when available and necessary.(Pulled out of #7794 to reduce that changeset's scope.)