Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csi: check returned volume capability validation #7831

Merged
merged 1 commit into from
Apr 30, 2020
Merged

csi: check returned volume capability validation #7831

merged 1 commit into from
Apr 30, 2020

Commits on Apr 29, 2020

  1. csi: check returned volume capability validation 

    This changeset corrects handling of the `ValidationVolumeCapabilities`
response:

* The CSI spec for the `ValidationVolumeCapabilities` requires that
  plugins only set the `Confirmed` field if they've validated all
  capabilities. The Nomad client improperly assumes that the lack of a
  `Confirmed` field should be treated as a failure. This breaks the
  Azure and Linode block storage plugins, which don't set this
  optional field.

* The CSI spec also requires that the orchestrator check the validation
  responses to guard against older versions of a plugin reporting
  "valid" for newer fields it doesn't understand.
    @tgross
    tgross committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    f11724f View commit details
    Browse the repository at this point in the history