Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder volume claim batch request raft message #7871

Merged
merged 1 commit into from
May 6, 2020

Conversation

tgross
Copy link
Member

@tgross tgross commented May 5, 2020

Fixes a regression I introduced in #7794 but we never shipped as a release.

For backwards compatibility of in-flight requests during upgrades, new raft message types
need to come at the end of the enum. But if we look at 0.11.1 we can see that wasn't done here.

@tgross tgross added this to the 0.11.2 milestone May 5, 2020
@tgross tgross requested review from langmartin and notnoop May 5, 2020 20:27
Copy link
Contributor

@langmartin langmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof, good catch. I just checked, this is in the contributing checklist, should we comment the constant block? I made this same bug early, also adding a batch request and still missed it in review ☹️ I can't find a linter that checks append only iota in a brief search.

For backwards compatibility during upgrades, new raft message types
need to come at the end of the enum.
@tgross tgross force-pushed the csi_batch_request_backwards_compat branch from f97d763 to 7c5cd22 Compare May 6, 2020 12:19
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - we should probably have a linter for this

Reminds me that we also need to change our numbering scheme once we get to 63 entries - Enterprise related raft entries start at value 64. Currently, CSIVolumeClaimBatchRequestType is ~39 so we still have some room before worrying about it so much.

@tgross tgross merged commit 5d03307 into master May 6, 2020
@tgross tgross deleted the csi_batch_request_backwards_compat branch May 6, 2020 12:57
@github-actions
Copy link

github-actions bot commented Jan 7, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants