Periodic GC for volume claims #7881
Conversation
tgross
force-pushed
the
csi_periodic_claim_gc
branch
2 times, most recently
from
d1a301e
to
cf20687
Compare
tgross
force-pushed
the
csi_periodic_claim_gc
branch
from
fbb3a09
to
95c2029
Compare
| job_gc_threshold = "12h" | ||
| eval_gc_threshold = "12h" | ||
| deployment_gc_threshold = "12h" | ||
| csi_volume_claim_gc_threshold = "12h" |
There was a problem hiding this comment.
This is the only new line. Curse you golang diffs! 😀
There was a problem hiding this comment.
but bless you github option to temporarily hide whitespace diffs
| JobGCInterval: "3m", | ||
| JobGCThreshold: "12h", | ||
| DeploymentGCThreshold: "12h", | ||
| CSIVolumeClaimGCThreshold: "12h", |
There was a problem hiding this comment.
This is the only new line. Thanks gofmt
| job_gc_threshold = "12h" | ||
| eval_gc_threshold = "12h" | ||
| deployment_gc_threshold = "12h" | ||
| csi_volume_claim_gc_threshold = "12h" |
There was a problem hiding this comment.
but bless you github option to temporarily hide whitespace diffs
| vol := i.(*structs.CSIVolume) | ||
|
|
||
| // Ignore new volumes | ||
| if vol.CreateIndex > oldThreshold { |
There was a problem hiding this comment.
Is the result of testing, or just a good idea? It seems like a pretty good idea either way.
There was a problem hiding this comment.
Inspired by the way we do it for job GC.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Finishes #7825, similar to #7878
This changeset implements a periodic garbage collection of CSI volumes with missing allocations. This can happen in a scenario where a node update fails partially and the allocation updates are written to raft but the evaluations to GC the volumes are dropped. This feature will cover this edge case and ensure that upgrades from 0.11.0 and 0.11.1 get any stray claims cleaned up.
I've tried to mirror the #7878 PR as much as possible here; best reviewed commit-by-commit as well.