Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker runtimes #7932

Merged
merged 8 commits into from
May 12, 2020
Merged

Docker runtimes #7932

merged 8 commits into from
May 12, 2020

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented May 12, 2020

Follow up to #7589 to add more tests and have an allow list for runtimes. The allowed list defaults to runc and nvidia.

Thanks @benbuzbee !

Ben Buzbee and others added 4 commits April 3, 2020 11:07
This enables customers who want to use gvisor and have it configured on their clients.
@notnoop notnoop requested a review from tgross May 12, 2020 14:22
@notnoop notnoop self-assigned this May 12, 2020
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few comments on the docs and wording of some of the messages.

website/pages/docs/drivers/docker.mdx Show resolved Hide resolved
website/pages/docs/drivers/docker.mdx Outdated Show resolved Hide resolved
drivers/docker/driver.go Outdated Show resolved Hide resolved
drivers/docker/driver.go Outdated Show resolved Hide resolved
Mahmood Ali and others added 4 commits May 12, 2020 10:56
Co-authored-by: Tim Gross <tgross@hashicorp.com>
Other allow lists use allow_ prefix (e.g. allow_caps, allow_privileged).
@notnoop notnoop merged commit dd06346 into master May 12, 2020
@notnoop notnoop deleted the f-docker-custom-runtimes branch May 12, 2020 15:59
@benbuzbee
Copy link
Contributor

Thanks @notnoop for following up, appreciate your openness. Excited to start using this

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants