Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changelog entry for stop_after_client_disconnect #7948

Merged
merged 1 commit into from
May 13, 2020
Merged

changelog entry for stop_after_client_disconnect #7948

merged 1 commit into from
May 13, 2020

Conversation

tgross
Copy link
Member

@tgross tgross commented May 13, 2020 •
edited
Loading

Requires #7939 and #7938 be merged.

Fixes the ordering so that core is first.

@tgross tgross force-pushed the changelog_stop_after_client_disconnect branch 2 times, most recently from a09aef9 to ffbfd79 Compare May 13, 2020 19:20
notnoop
notnoop approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

notnoop
notnoop reviewed May 13, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tgross tgross force-pushed the changelog_stop_after_client_disconnect branch from ffbfd79 to a44b62c Compare May 13, 2020 19:22
@shoenig shoenig mentioned this pull request May 13, 2020
Merged
@cgbaker cgbaker added this to the 0.11.2 milestone May 13, 2020
@tgross
Copy link
Member Author

tgross commented May 13, 2020

Safely closed by #7949

@tgross tgross closed this May 13, 2020
@tgross tgross reopened this May 13, 2020
@tgross tgross force-pushed the changelog_stop_after_client_disconnect branch from a44b62c to 55cf0a6 Compare May 13, 2020 20:42
@tgross
Copy link
Member Author

tgross commented May 13, 2020

Rebased on master

cgbaker
cgbaker approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cgbaker cgbaker merged commit 770a7a6 into master May 13, 2020
@cgbaker cgbaker deleted the changelog_stop_after_client_disconnect branch May 13, 2020 20:43
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@notnoop notnoop notnoop approved these changes

@langmartin langmartin langmartin approved these changes

@cgbaker cgbaker cgbaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.2
Development

Successfully merging this pull request may close these issues.
4 participants
@tgross @langmartin @notnoop @cgbaker