Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: add filesystem browsing for allocations #7951

Merged
merged 34 commits into from
Jun 1, 2020
Merged

UI: add filesystem browsing for allocations #7951

merged 34 commits into from
Jun 1, 2020

Commits on May 13, 2020

  1. Add hack to allow allocation filesystem browsing

    There’s a lot of duplication here that’s probably worth extracting
    despite not meeting the three-repetitions rule because we were
    already simulating the API being for a task by including the task
    name in the URL.
    backspace committed May 13, 2020
    Configuration menu
    Copy the full SHA
    9f86b22 View commit details
    Browse the repository at this point in the history
  2. Fix title

    backspace committed May 13, 2020
    Configuration menu
    Copy the full SHA
    796883c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c4bf88c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    14f11b5 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2020

  1. Add preliminary acceptance tests

    This is a barely-different copypaste from the task fs acceptance
    tests… I’m not sure what’s the best way to accomplish this!
    backspace committed May 19, 2020
    Configuration menu
    Copy the full SHA
    db0421a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4fd9f40 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3b964c1 View commit details
    Browse the repository at this point in the history
  4. Remove stripping of leading task name in paths

    The assumption that we should strip the task name path prefix
    is no longer correct if we want to be able to browse the
    allocation without a task. This changes the task filesystem
    acceptance test files to all be nested within a task name
    directory, which mirrors how it works in the real setup.
    backspace committed May 19, 2020
    Configuration menu
    Copy the full SHA
    c565940 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5137395 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c2062e9 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. Remove logs link

    backspace committed May 20, 2020
    Configuration menu
    Copy the full SHA
    8ae2fd5 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2020

  1. Configuration menu
    Copy the full SHA
    4781a59 View commit details
    Browse the repository at this point in the history
  2. Extract more shared tests

    The interface here is still subpar, with the expectations of
    the various things dangling off `this.` (files? directory?),
    but maybe some cleanup is possible…
    backspace committed May 27, 2020
    Configuration menu
    Copy the full SHA
    d876037 View commit details
    Browse the repository at this point in the history
  3. Extract all other tests

    There’s one left that has some duplication but it doesn’t
    seem worth extracting due to how much customisation it
    would require.
    backspace committed May 27, 2020
    Configuration menu
    Copy the full SHA
    96da717 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Combine breadcrumbs components

    Another combination could happen if I extract something like
    an fs-link component 🤔
    backspace committed May 28, 2020
    Configuration menu
    Copy the full SHA
    cc0d491 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b20f0b9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d3df8c5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4b77ffb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1e33b69 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8e4f352 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2ed5c43 View commit details
    Browse the repository at this point in the history
  8. Extract fs link component

    This contains some of the duplication scattered about where
    filesystem links are slightly different in two dimensions.
    backspace committed May 28, 2020
    Configuration menu
    Copy the full SHA
    891b929 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e9eb924 View commit details
    Browse the repository at this point in the history
  10. Extract model determination to one place

    There’s no need to have these calculations scattered everywhere.
    backspace committed May 28, 2020
    Configuration menu
    Copy the full SHA
    f4c5a8e View commit details
    Browse the repository at this point in the history
  11. Remove unused import

    backspace committed May 28, 2020
    Configuration menu
    Copy the full SHA
    411cbb0 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    91bf699 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    6b0667f View commit details
    Browse the repository at this point in the history
  14. Remove task state adapter

    It makes more sense to concentrate these functions in the
    allocation adapter.
    backspace committed May 28, 2020
    Configuration menu
    Copy the full SHA
    8d688b2 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    b3a620a View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    3bbc718 View commit details
    Browse the repository at this point in the history
  17. Change order of imports

    I’d LOVE for some Prettier-esque approach to this 😝
    backspace committed May 28, 2020
    Configuration menu
    Copy the full SHA
    018737c View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    d2ba531 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. Configuration menu
    Copy the full SHA
    e634f9c View commit details
    Browse the repository at this point in the history
  2. Update changelog

    backspace committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    5f82c18 View commit details
    Browse the repository at this point in the history