-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: add filesystem browsing for allocations #7951
Commits on May 13, 2020
-
Add hack to allow allocation filesystem browsing
There’s a lot of duplication here that’s probably worth extracting despite not meeting the three-repetitions rule because we were already simulating the API being for a task by including the task name in the URL.
Configuration menu - View commit details
-
Copy full SHA for 9f86b22 - Browse repository at this point
Copy the full SHA 9f86b22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 796883c - Browse repository at this point
Copy the full SHA 796883cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4bf88c - Browse repository at this point
Copy the full SHA c4bf88cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 14f11b5 - Browse repository at this point
Copy the full SHA 14f11b5View commit details
Commits on May 19, 2020
-
Add preliminary acceptance tests
This is a barely-different copypaste from the task fs acceptance tests… I’m not sure what’s the best way to accomplish this!
Configuration menu - View commit details
-
Copy full SHA for db0421a - Browse repository at this point
Copy the full SHA db0421aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fd9f40 - Browse repository at this point
Copy the full SHA 4fd9f40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b964c1 - Browse repository at this point
Copy the full SHA 3b964c1View commit details -
Remove stripping of leading task name in paths
The assumption that we should strip the task name path prefix is no longer correct if we want to be able to browse the allocation without a task. This changes the task filesystem acceptance test files to all be nested within a task name directory, which mirrors how it works in the real setup.
Configuration menu - View commit details
-
Copy full SHA for c565940 - Browse repository at this point
Copy the full SHA c565940View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5137395 - Browse repository at this point
Copy the full SHA 5137395View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2062e9 - Browse repository at this point
Copy the full SHA c2062e9View commit details
Commits on May 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8ae2fd5 - Browse repository at this point
Copy the full SHA 8ae2fd5View commit details
Commits on May 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4781a59 - Browse repository at this point
Copy the full SHA 4781a59View commit details -
The interface here is still subpar, with the expectations of the various things dangling off `this.` (files? directory?), but maybe some cleanup is possible…
Configuration menu - View commit details
-
Copy full SHA for d876037 - Browse repository at this point
Copy the full SHA d876037View commit details -
There’s one left that has some duplication but it doesn’t seem worth extracting due to how much customisation it would require.
Configuration menu - View commit details
-
Copy full SHA for 96da717 - Browse repository at this point
Copy the full SHA 96da717View commit details
Commits on May 28, 2020
-
Combine breadcrumbs components
Another combination could happen if I extract something like an fs-link component 🤔
Configuration menu - View commit details
-
Copy full SHA for cc0d491 - Browse repository at this point
Copy the full SHA cc0d491View commit details -
Configuration menu - View commit details
-
Copy full SHA for b20f0b9 - Browse repository at this point
Copy the full SHA b20f0b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3df8c5 - Browse repository at this point
Copy the full SHA d3df8c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b77ffb - Browse repository at this point
Copy the full SHA 4b77ffbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e33b69 - Browse repository at this point
Copy the full SHA 1e33b69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e4f352 - Browse repository at this point
Copy the full SHA 8e4f352View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ed5c43 - Browse repository at this point
Copy the full SHA 2ed5c43View commit details -
This contains some of the duplication scattered about where filesystem links are slightly different in two dimensions.
Configuration menu - View commit details
-
Copy full SHA for 891b929 - Browse repository at this point
Copy the full SHA 891b929View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9eb924 - Browse repository at this point
Copy the full SHA e9eb924View commit details -
Extract model determination to one place
There’s no need to have these calculations scattered everywhere.
Configuration menu - View commit details
-
Copy full SHA for f4c5a8e - Browse repository at this point
Copy the full SHA f4c5a8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 411cbb0 - Browse repository at this point
Copy the full SHA 411cbb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91bf699 - Browse repository at this point
Copy the full SHA 91bf699View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b0667f - Browse repository at this point
Copy the full SHA 6b0667fView commit details -
It makes more sense to concentrate these functions in the allocation adapter.
Configuration menu - View commit details
-
Copy full SHA for 8d688b2 - Browse repository at this point
Copy the full SHA 8d688b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3a620a - Browse repository at this point
Copy the full SHA b3a620aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bbc718 - Browse repository at this point
Copy the full SHA 3bbc718View commit details -
I’d LOVE for some Prettier-esque approach to this 😝
Configuration menu - View commit details
-
Copy full SHA for 018737c - Browse repository at this point
Copy the full SHA 018737cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d2ba531 - Browse repository at this point
Copy the full SHA d2ba531View commit details
Commits on Jun 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e634f9c - Browse repository at this point
Copy the full SHA e634f9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f82c18 - Browse repository at this point
Copy the full SHA 5f82c18View commit details