Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault: ensure that token revocation is idempotent #7959

Merged
merged 2 commits into from
May 14, 2020
Merged

vault: ensure that token revocation is idempotent #7959

merged 2 commits into from
May 14, 2020

Commits on May 14, 2020

  1. vault: failing test for repeated revocation

    Mahmood Ali committed May 14, 2020
    Configuration menu
    Copy the full SHA
    1f78c55 View commit details
    Browse the repository at this point in the history

  2. vault: ensure that token revocation is idempotent 

    This ensures that token revocation is idempotent and can handle when
tokens are revoked out of band.

Idempotency is important to handle some transient failures and retries.
Consider when a single token of a batch fails to be revoked, nomad would
retry revoking the entire batch; tokens already revoked should be
gracefully handled, otherwise, nomad may retry revoking the same
tokens forever.
    Mahmood Ali committed May 14, 2020
    Configuration menu
    Copy the full SHA
    ff3cf8f View commit details
    Browse the repository at this point in the history