Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csi: improve plugin error messages and volume validation #7984

Merged
merged 1 commit into from
May 18, 2020

Commits on May 15, 2020

  1. csi: improve plugin error messages and volume validation

    Some CSI plugins don't return much for errors over the gRPC socket
    above and beyond the bare minimum error codes. This changeset improves
    the operator experience by unpacking the error codes when available
    and wrapping the error with some user-friendly direction.
    
    Improving these errors also revealed a bad comparison with
    `require.Error` when `require.EqualError` should be used in the test
    code for plugin errors. This defect in turn was hiding a bug in volume
    validation where we're being overly permissive in allowing mount
    flags, which is now fixed.
    tgross committed May 15, 2020
    Configuration menu
    Copy the full SHA
    1a6b5ab View commit details
    Browse the repository at this point in the history