Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csi: don't pass volume claim releases thru GC eval #8021

Merged
merged 3 commits into from
May 20, 2020
Merged

csi: don't pass volume claim releases thru GC eval #8021

merged 3 commits into from
May 20, 2020

Commits on May 20, 2020

  1. csi: don't pass volume claim releases thru GC eval 

    Following the new volumewatcher in #7794 and performance improvements
to it that landed afterwards, there's no particular reason we should
be threading claim releases through the GC eval rather than writing an
empty `CSIVolumeClaimRequest` with the mode set to
`CSIVolumeClaimRelease`, just as the GC evaluation would do.

Also, by batching up these raft messages, we can reduce the amount of
raft writes by 1 and cross-server RPCs by 1 per volume we release
claims on.
    @tgross
    tgross committed May 20, 2020
    Configuration menu
    Copy the full SHA
    a012a56 View commit details
    Browse the repository at this point in the history

  2. resolve comments from code review

    @tgross
    tgross committed May 20, 2020
    Configuration menu
    Copy the full SHA
    54bde4d View commit details
    Browse the repository at this point in the history

  3. fix de-duplication bug and add test for it

    @tgross
    tgross committed May 20, 2020
    Configuration menu
    Copy the full SHA
    d2a1a7f View commit details
    Browse the repository at this point in the history