Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deflake some tests - 2020-05-27 edition #8060

Merged
merged 8 commits into from
May 27, 2020
Merged

Deflake some tests - 2020-05-27 edition #8060

merged 8 commits into from
May 27, 2020

Commits on May 26, 2020

  1. tests: eval may be processed quickly

    Mahmood Ali committed May 26, 2020
    Configuration menu
    Copy the full SHA
    612dd36 View commit details
    Browse the repository at this point in the history

  2. tests: don't delete images after tests complete 

    Fix some docker test flakiness where image cleanup process may
contaminate other tests. A clean up process may attempt to delete an
image while it's used by another test.
    Mahmood Ali committed May 26, 2020
    Configuration menu
    Copy the full SHA
    5de673e View commit details
    Browse the repository at this point in the history

  3. tests: wait until clients are in the state store

    Mahmood Ali committed May 26, 2020
    Configuration menu
    Copy the full SHA
    50c9a0a View commit details
    Browse the repository at this point in the history

Commits on May 27, 2020

  1. don't GC images in tests by default

    Mahmood Ali committed May 27, 2020
    Configuration menu
    Copy the full SHA
    76324a1 View commit details
    Browse the repository at this point in the history

  2. tests: node drain events may be duplicated

    Mahmood Ali committed May 27, 2020
    Configuration menu
    Copy the full SHA
    41a450c View commit details
    Browse the repository at this point in the history

  3. gracefully shutdown test server

    Mahmood Ali committed May 27, 2020
    Configuration menu
    Copy the full SHA
    bcc4ec9 View commit details
    Browse the repository at this point in the history

  4. tests: use t.Fatalf when it's clearer

    Mahmood Ali committed May 27, 2020
    Configuration menu
    Copy the full SHA
    35d039e View commit details
    Browse the repository at this point in the history

  5. tests: use GreaterOrEqual and apply change to other tests

    Mahmood Ali committed May 27, 2020
    Configuration menu
    Copy the full SHA
    74af591 View commit details
    Browse the repository at this point in the history