Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add rendering of poststop tasks #8117

Closed
wants to merge 1 commit into from
Closed

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Jun 4, 2020

This adds a new poststop lifecycle phase:

image

It relies on #8194.

@github-actions
Copy link

github-actions bot commented Jun 4, 2020

Ember Asset Size action

As of dd34ab2

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +394 B +55 B
nomad-ui.css +320 B +41 B

Files that stayed the same size 🤷‍:

File raw gzip
auto-import-fastboot.js 0 B 0 B
vendor.js 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Jun 4, 2020

Ember Test Audit comparison

master dd34ab2 change
passes 1425 1425 0
failures 0 0 0
flaky 0 0 0
duration 5m 29s 138ms 5m 25s 626ms -03s 512ms

@backspace
Copy link
Contributor Author

I’ve tried this locally with a dev build of this branch and it works:

image

So I think it can be reviewed but we can hold off merging until that branch is ready.

@backspace backspace marked this pull request as ready for review June 22, 2020 13:18
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant