Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler/reconcile: set FollowupEvalID on lost stop_after_client_disconnect #8138

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

langmartin
Copy link
Contributor

@langmartin langmartin commented Jun 9, 2020

This is a cherry-pick onto master from the release-0.11.3 branch, containing the squashed pr #8105.

scheduler/reconcile: set FollowupEvalID on lost stop_after_client_disconnect (#8105)

  • scheduler/reconcile: set FollowupEvalID on lost stop_after_client_disconnect

  • scheduler/reconcile: thread follupEvalIDs through to results.stop

  • scheduler/reconcile: comment typo

  • nomad/_test: correct arguments for plan.AppendStoppedAlloc

  • scheduler/reconcile: avoid nil, cleanup handleDelayed(Lost|Reschedules)

…connect (#8105)

* scheduler/reconcile: set FollowupEvalID on lost stop_after_client_disconnect

* scheduler/reconcile: thread follupEvalIDs through to results.stop

* scheduler/reconcile: comment typo

* nomad/_test: correct arguments for plan.AppendStoppedAlloc

* scheduler/reconcile: avoid nil, cleanup handleDelayed(Lost|Reschedules)
@langmartin langmartin changed the title scheduler/reconcile: set FollowupEvalID on lost stop_after_client_dis… scheduler/reconcile: set FollowupEvalID on lost stop_after_client_disconnect Jun 9, 2020
@langmartin langmartin requested a review from cgbaker June 9, 2020 17:43
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just did a cursory review since this was already reviewed 👍

@langmartin langmartin merged commit 9ccec0a into master Jun 9, 2020
@langmartin langmartin deleted the p-cherry-release-0.11.3 branch June 9, 2020 21:13
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants