-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add phase 1 search #8175
UI: Add phase 1 search #8175
Commits on Jun 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e919f00 - Browse repository at this point
Copy the full SHA e919f00View commit details -
This is an ungainly integration with the searchable mixin 😳
Configuration menu - View commit details
-
Copy full SHA for 73b6bb3 - Browse repository at this point
Copy the full SHA 73b6bb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b46679 - Browse repository at this point
Copy the full SHA 6b46679View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fca80e - Browse repository at this point
Copy the full SHA 8fca80eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00ced6f - Browse repository at this point
Copy the full SHA 00ced6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a7ded9b - Browse repository at this point
Copy the full SHA a7ded9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b24f73b - Browse repository at this point
Copy the full SHA b24f73bView commit details -
I’d prefer for this to be covered by automated tests but it seems like it only half-works… the placeholder in the field disappears with the use of keyDown but the field doesn’t look active. Actually pressing / does work though.
Configuration menu - View commit details
-
Copy full SHA for 180f54a - Browse repository at this point
Copy the full SHA 180f54aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7cc5f5 - Browse repository at this point
Copy the full SHA e7cc5f5View commit details
Commits on Jun 17, 2020
-
Expand scope of try to catch more errors
Has it always been that errors are silently swallowed? Mysterious
Configuration menu - View commit details
-
Copy full SHA for 94f42d0 - Browse repository at this point
Copy the full SHA 94f42d0View commit details -
Change to use set for search properties
With the expanded try, I found that the reason for search only working once was that it was required to use set for these properties, I guess because they’re used by computed properties.
Configuration menu - View commit details
-
Copy full SHA for de076d6 - Browse repository at this point
Copy the full SHA de076d6View commit details -
Change interface for search classes
This is still unwieldly but maybe a bit more sensible now.
Configuration menu - View commit details
-
Copy full SHA for db0ceac - Browse repository at this point
Copy the full SHA db0ceacView commit details -
Stop control from capturing / in input fields
I’ve adapted the listener from @DingoEatingFuzz’s keyboard event- handling here, obviating the need for ember-keyboard: https://github.com/hashicorp/nomad/pull/8177/files#diff-eb4d61e1e080830b844012c6617c6fa2 The filtering to prevent stealing events from input fields is adapted from here: https://stackoverflow.com/a/4171758
Configuration menu - View commit details
-
Copy full SHA for a213176 - Browse repository at this point
Copy the full SHA a213176View commit details -
Add preliminary use of cached collections
This still means a query will be sent for every search, but if we’re in a route we know has a watched collection, the cached collection will be used.
Configuration menu - View commit details
-
Copy full SHA for 2fa2ef8 - Browse repository at this point
Copy the full SHA 2fa2ef8View commit details
Commits on Jun 18, 2020
-
Remove manual vertical positioning of divider
Since the container now has align-items: center, this is no longer needed.
Configuration menu - View commit details
-
Copy full SHA for def4851 - Browse repository at this point
Copy the full SHA def4851View commit details -
This isn’t perfect as it only updates the last-fetched time of a watched collection when a search is performed. It also has the cache duration as 5s which is probably too short.
Configuration menu - View commit details
-
Copy full SHA for a9f97cb - Browse repository at this point
Copy the full SHA a9f97cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95904b7 - Browse repository at this point
Copy the full SHA 95904b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44c4f1c - Browse repository at this point
Copy the full SHA 44c4f1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 93602c0 - Browse repository at this point
Copy the full SHA 93602c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd14f25 - Browse repository at this point
Copy the full SHA fd14f25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 379ad0c - Browse repository at this point
Copy the full SHA 379ad0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 894de23 - Browse repository at this point
Copy the full SHA 894de23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5749ec1 - Browse repository at this point
Copy the full SHA 5749ec1View commit details
Commits on Jun 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e4e7c78 - Browse repository at this point
Copy the full SHA e4e7c78View commit details