Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add phase 1 search #8175

Merged
merged 24 commits into from
Jun 19, 2020
Merged

UI: Add phase 1 search #8175

merged 24 commits into from
Jun 19, 2020

Commits on Jun 16, 2020

  1. Add inert search components

    backspace committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    e919f00 View commit details
    Browse the repository at this point in the history
  2. Add preliminary job search

    This is an ungainly integration with the searchable mixin 😳
    backspace committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    73b6bb3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6b46679 View commit details
    Browse the repository at this point in the history
  4. Add client search

    backspace committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    8fca80e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    00ced6f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a7ded9b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b24f73b View commit details
    Browse the repository at this point in the history
  8. Add / shortcut to open search

    I’d prefer for this to be covered by automated tests but
    it seems like it only half-works… the placeholder in
    the field disappears with the use of keyDown but the
    field doesn’t look active. Actually pressing / does
    work though.
    backspace committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    180f54a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e7cc5f5 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Expand scope of try to catch more errors

    Has it always been that errors are silently swallowed?
    Mysterious
    backspace committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    94f42d0 View commit details
    Browse the repository at this point in the history
  2. Change to use set for search properties

    With the expanded try, I found that the reason for search
    only working once was that it was required to use set for
    these properties, I guess because they’re used by
    computed properties.
    backspace committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    de076d6 View commit details
    Browse the repository at this point in the history
  3. Change interface for search classes

    This is still unwieldly but maybe a bit more sensible now.
    backspace committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    db0ceac View commit details
    Browse the repository at this point in the history
  4. Stop control from capturing / in input fields

    I’ve adapted the listener from @DingoEatingFuzz’s keyboard event-
    handling here, obviating the need for ember-keyboard:
    https://github.com/hashicorp/nomad/pull/8177/files#diff-eb4d61e1e080830b844012c6617c6fa2
    
    The filtering to prevent stealing events from input fields
    is adapted from here:
    https://stackoverflow.com/a/4171758
    backspace committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    a213176 View commit details
    Browse the repository at this point in the history
  5. Add preliminary use of cached collections

    This still means a query will be sent for every search, but
    if we’re in a route we know has a watched collection, the
    cached collection will be used.
    backspace committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    2fa2ef8 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. Remove manual vertical positioning of divider

    Since the container now has align-items: center, this is
    no longer needed.
    backspace committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    def4851 View commit details
    Browse the repository at this point in the history
  2. Add time-based caching

    This isn’t perfect as it only updates the last-fetched time
    of a watched collection when a search is performed. It also
    has the cache duration as 5s which is probably too short.
    backspace committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    a9f97cb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    95904b7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    44c4f1c View commit details
    Browse the repository at this point in the history
  5. Change cache duration

    backspace committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    93602c0 View commit details
    Browse the repository at this point in the history
  6. Fix assertion description

    backspace committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    fd14f25 View commit details
    Browse the repository at this point in the history
  7. Remove/update notes

    backspace committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    379ad0c View commit details
    Browse the repository at this point in the history
  8. Remove/update notes

    backspace committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    894de23 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5749ec1 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. Configuration menu
    Copy the full SHA
    e4e7c78 View commit details
    Browse the repository at this point in the history