Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add linting for classic decorator #8182

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Jun 17, 2020

This completes the second installation step I missed when making the class migration PR and marks classes as @classic that are using the EmberObject APIs.

@backspace backspace self-assigned this Jun 17, 2020
@backspace backspace marked this pull request as draft June 17, 2020 13:14
@github-actions
Copy link

github-actions bot commented Jun 17, 2020

Ember Asset Size action

As of 38f3bdf

Files that stayed the same size 🤷‍:

File raw gzip
auto-import-fastboot.js 0 B 0 B
nomad-ui.js 0 B 0 B
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Jun 17, 2020

Ember Test Audit comparison

master 38f3bdf change
passes 1425 1424 -1
failures 0 1 +1
flaky 0 0 0
duration 5m 27s 715ms 000ms -5m 27s 715ms

This is a part of the installation that I missed 😞
@backspace backspace force-pushed the b-ui/classic-decorator-rules branch from 28ac4eb to 38f3bdf Compare June 22, 2020 14:45
@backspace backspace marked this pull request as ready for review June 22, 2020 15:12
@backspace
Copy link
Contributor Author

The test failure is surely unrelated, another instance where the test audit comparison action swallows useful information 😞

@backspace backspace merged commit 068ad06 into master Jun 22, 2020
@backspace backspace deleted the b-ui/classic-decorator-rules branch June 22, 2020 15:48
@github-actions
Copy link

github-actions bot commented Jan 2, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants