csi: add VolumeContext to NodeStage/Publish RPCs #8239
Merged
+95
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
b-csi-volume-context-missing-for-node-api
branch
from
49dc29b
to
cdc5431
Compare
shoenig
approved these changes
Jun 22, 2020
tgross
force-pushed
the
b-csi-volume-context-missing-for-node-api
branch
2 times, most recently
from
139bba1
to
66c6ba9
Compare
In #7957 we added support for passing a volume context to the controller RPCs. This is an opaque map that's created by `CreateVolume` or, in Nomad's case, in the volume registration spec. However, we missed passing this field to the `NodeStage` and `NodePublish` RPC, which prevents certain plugins (such as MooseFS) from making node RPCs.
tgross
force-pushed
the
b-csi-volume-context-missing-for-node-api
branch
from
66c6ba9
to
901664f
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7771
In #7957 we added support for passing a volume context to the controller RPCs.
This is an opaque map that's created by
CreateVolumeor, in Nomad's case,in the volume registration spec.
However, we missed passing this field to the
NodeStageandNodePublishRPC,which prevents certain plugins (such as MooseFS) from making node RPCs.