Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Update to Ember 3.16/Data 3.12 #8319

Merged
merged 5 commits into from
Jul 9, 2020
Merged

UI: Update to Ember 3.16/Data 3.12 #8319

merged 5 commits into from
Jul 9, 2020

Commits on Jun 30, 2020

  1. Add results of ember-cli-update to 3.16 

    Some interventions:
* changing template lint back to “recommended” vs “octane”
* returning Ember Data to 3.12
* deleted config/ember-cli-update.json
    @backspace
    backspace committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    d4185cf View commit details
    Browse the repository at this point in the history

  2. Add guard against missing allocationId 

    This was throwing an error trying to fetch a non-existent id.
    @backspace
    backspace committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    82af49a View commit details
    Browse the repository at this point in the history

  3. Add guard against undefined source

    @backspace
    backspace committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    1158c32 View commit details
    Browse the repository at this point in the history

  4. Remove template-only component setting 

    The ClientDetail.attributesTable assertion was failing because
it becoming a template-only component meant that the
data-test-attributes selector had no element to attach to.

Having the edition set to Octane in package.json causes an error
to be thrown when template-only-glimmer-components is turned
off, so it’ll have to go for now.
    @backspace
    backspace committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    c0ccd82 View commit details
    Browse the repository at this point in the history

  5. Remove partials 

    This is mostly a direct replacement of partials with components.
In some cases, the components needed a layout or injected services
that were formerly available via containing scope.
    @backspace
    backspace committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    66e55aa View commit details
    Browse the repository at this point in the history