Change connectDriverConfig to be a func #8338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. The tests are failing with a compile error. Mind if you update and we can merge? Thank you so much for your effort! |
jorgemarey
force-pushed
the
b-fix-sidecar-task
branch
from
f626a64
to
46584b9
Compare
|
Hi @notnoop, the compile error is fixed. |
shoenig
approved these changes
Jul 8, 2020
|
Thanks @jorgemarey , this is great! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8337
Change the connectDriverConfig to be a function that returns the configuration map. Otherwise when that map is modified,
all new sidecar task will get that same configuration.