Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better error handling around Scaling->Max #8360

Merged
merged 5 commits into from
Jul 6, 2020
Merged

better error handling around Scaling->Max #8360

merged 5 commits into from
Jul 6, 2020

Commits on Jul 4, 2020

  1. added scaling->min default discussion to group->count documentation

    @cgbaker
    cgbaker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    f015e02 View commit details
    Browse the repository at this point in the history

  2. changes to make sure that Max is present and valid, to improve error … 

    …messages

* made api.Scaling.Max a pointer, so we can detect (and complain) when it is neglected
* added checks to HCL parsing that it is present
* when Scaling.Max is absent/invalid, don't return extraneous error messages during validation
* tweak to multiregion handling to ensure that the count is valid on the interpolated regional jobs

resolves #8355
    @cgbaker
    cgbaker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    7f8176a View commit details
    Browse the repository at this point in the history

  3. added changelog entry for #8360

    @cgbaker
    cgbaker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    a05f3af View commit details
    Browse the repository at this point in the history

  4. fixed api tests for changes

    @cgbaker
    cgbaker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    15a66e6 View commit details
    Browse the repository at this point in the history

  5. better testing of scaling parsing, fixed some broken tests by api 

    changes
    @cgbaker
    cgbaker committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    b5f595a View commit details
    Browse the repository at this point in the history