UI: add explicit this to templates #8388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Asset Size actionAs of a1069da Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
20 tasks
DingoEatingFuzz
approved these changes
Jul 9, 2020
backspace
force-pushed
the
b-ui/angle-brackets-missed
branch
from
0996188
to
957a63e
Compare
backspace
force-pushed
the
f-ui/no-implicit-this
branch
from
f44b76e
to
42a9d83
Compare
Ember Test Audit comparison
|
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of running the
no-implicit-this-codemod, some manual fixes,and the addition of a linting rule to prevent future ambiguity.
(This is set to merge into #8382 for now as it’s branched off it.)