Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomad: recanonicalize network after connect hook #8407

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

nickethier
Copy link
Member

With the addition of host_network to the port block, the group network needs to be re-canonicalized to set correct defaults.

@nickethier nickethier requested a review from shoenig July 9, 2020 19:08
@shoenig
Copy link
Member

shoenig commented Jul 10, 2020

needs test fix

 TestJobEndpointConnect_groupConnectHook: job_endpoint_hook_connect_test.go:105:

@nickethier nickethier merged commit 3962eec into master Jul 10, 2020
@nickethier nickethier deleted the b-connect-default-host-network branch July 10, 2020 14:59
@tgross tgross added this to the 0.12.1 milestone Jul 20, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants