Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix client allocations table heading order #8409

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

backspace
Copy link
Contributor

This closes #8408. Thanks to @gmichalec-pandora for letting us
know about this.

This closes #8408. Thanks to @gmichalec-pandora for letting us
know about this.
@github-actions
Copy link

github-actions bot commented Jul 9, 2020

Ember Asset Size action

As of 5c9eb8d

Files that stayed the same size 🤷‍:

File raw gzip
nomad-ui.js 0 B -1 B
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Jul 9, 2020

Ember Test Audit comparison

master 5c9eb8d change
passes 1287 1287 0
failures 0 0 0
flaky 0 0 0
duration 6m 01s 664ms 5m 51s 789ms -09s 875ms

Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

@backspace
Copy link
Contributor Author

yeah, I missed it when reviewing too 🙃

It reminds me of this table frustration, something I’ve thought for years was bug-prone and hard to test. Not catastrophic though at least!

@backspace backspace merged commit 121cd13 into master Jul 10, 2020
@backspace backspace deleted the b-ui/client-allocations-th-order branch July 10, 2020 12:27
backspace added a commit that referenced this pull request Jul 10, 2020
backspace added a commit that referenced this pull request Jul 10, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nomad UI Client view Allocation Create/Modified labels are backwards
2 participants