Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul/connect: add support for bridge networks with connect native tasks #8443

Merged
merged 4 commits into from
Jul 29, 2020
Merged

consul/connect: add support for bridge networks with connect native tasks #8443

merged 4 commits into from
Jul 29, 2020

Commits on Jul 29, 2020

  1. consul/connect: add support for bridge networks with connect native t… 

    …asks

Before, Connect Native Tasks needed one of these to work:

- To be run in host networking mode
- To have the Consul agent configured to listen to a unix socket
- To have the Consul agent configured to listen to a public interface

None of these are a great experience, though running in host networking is
still the best solution for non-Linux hosts. This PR establishes a connection
proxy between the Consul HTTP listener and a unix socket inside the alloc fs,
bypassing the network namespace for any Connect Native task. Similar to and
re-uses a bunch of code from the gRPC listener version for envoy sidecar proxies.

Proxy is established only if the alloc is configured for bridge networking and
there is at least one Connect Native task in the Task Group.

Fixes #8290
    @shoenig
    shoenig committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    8ec3aa1 View commit details
    Browse the repository at this point in the history

  2. consul/connect: optimze grpc socket hook check for bridge network first

    @shoenig
    shoenig committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    6c6f3d9 View commit details
    Browse the repository at this point in the history

  3. consul/connect: organize lock & fields in http/grpc socket hooks

    @shoenig
    shoenig committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    b54fe19 View commit details
    Browse the repository at this point in the history

  4. consul/connect: fixup some spelling, comments, consts

    @shoenig
    shoenig committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    1918c2d View commit details
    Browse the repository at this point in the history