-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add acceptance test accessibility auditing and fixes #8455
Merged
Commits on Jul 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ea4a7ee - Browse repository at this point
Copy the full SHA ea4a7eeView commit details
Commits on Jul 20, 2020
-
This lets us centralise rule exclusions instead of having them sprinkled around in test files.
Configuration menu - View commit details
-
Copy full SHA for a860994 - Browse repository at this point
Copy the full SHA a860994View commit details
Commits on Jul 21, 2020
-
Add accessibility audits to acceptance tests
I’m torn about whether this approach of making separate tests for the audit is preferable to embedding the audit in the existing tests, perhaps similarly to how assertions on the page title are embedded. 🤔
Configuration menu - View commit details
-
Copy full SHA for d06919b - Browse repository at this point
Copy the full SHA d06919bView commit details -
Some of these (color-contrast and heading-order) will be harder to fix than others, but I will hopefully be able to address the majority in subsequent commits.
Configuration menu - View commit details
-
Copy full SHA for c1fde7f - Browse repository at this point
Copy the full SHA c1fde7fView commit details -
This rule is described here: https://dequeuniversity.com/rules/axe/3.5/svg-img-alt
Configuration menu - View commit details
-
Copy full SHA for a3bf4b0 - Browse repository at this point
Copy the full SHA a3bf4b0View commit details -
This rule is described here: https://dequeuniversity.com/rules/axe/3.5/link-name
Configuration menu - View commit details
-
Copy full SHA for 7625142 - Browse repository at this point
Copy the full SHA 7625142View commit details
Commits on Jul 22, 2020
-
This rule is described here: https://dequeuniversity.com/rules/axe/3.5/landmark-unique
Configuration menu - View commit details
-
Copy full SHA for e5786ef - Browse repository at this point
Copy the full SHA e5786efView commit details -
This rule is described here: https://dequeuniversity.com/rules/axe/3.5/label While adding a label for the token input field, I noticed that its placeholder produces a bad VoiceOver experience, which I will address separately. I removed the action to focus the stepper input when clicking the label as I believe connecting the label and input with an id is equivalent. This includes an override for ivy-codemirror’s codemirror dependency to take advantage of the screenReaderLabel configuration option in 5.53; thanks to @adityatoshniwal for that addition in codemirror/codemirror5#6197.
Configuration menu - View commit details
-
Copy full SHA for a5c433e - Browse repository at this point
Copy the full SHA a5c433eView commit details
Commits on Jul 23, 2020
-
This rule is described here: https://dequeuniversity.com/rules/axe/3.5/button-name For the log streaming toggles, normally I would assert against conditionals like these, but I couldn’t find any assertions on the icons 😯
Configuration menu - View commit details
-
Copy full SHA for cdbab70 - Browse repository at this point
Copy the full SHA cdbab70View commit details -
This turns off one rule for the job definition test, as the CodeMirror component is failing: https://dequeuniversity.com/rules/axe/3.5/scrollable-region-focusable
Configuration menu - View commit details
-
Copy full SHA for 4095504 - Browse repository at this point
Copy the full SHA 4095504View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.