Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add acceptance test accessibility auditing and fixes #8455

Merged
merged 10 commits into from
Jul 28, 2020

Commits on Jul 17, 2020

  1. Add ember-a11y-testing

    backspace committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    ea4a7ee View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. Add a11yAudit helper

    This lets us centralise rule exclusions instead of having them
    sprinkled around in test files.
    backspace committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    a860994 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Add accessibility audits to acceptance tests

    I’m torn about whether this approach of making separate tests
    for the audit is preferable to embedding the audit in the
    existing tests, perhaps similarly to how assertions on the
    page title are embedded. 🤔
    backspace committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    d06919b View commit details
    Browse the repository at this point in the history
  2. Add rule exclusions

    Some of these (color-contrast and heading-order) will be
    harder to fix than others, but I will hopefully be able
    to address the majority in subsequent commits.
    backspace committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    c1fde7f View commit details
    Browse the repository at this point in the history
  3. Fix svg-img-alt failure

    backspace committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    a3bf4b0 View commit details
    Browse the repository at this point in the history
  4. Fix link-name failures

    backspace committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    7625142 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2020

  1. Configuration menu
    Copy the full SHA
    e5786ef View commit details
    Browse the repository at this point in the history
  2. Fix label failures

    This rule is described here:
    https://dequeuniversity.com/rules/axe/3.5/label
    
    While adding a label for the token input field, I noticed
    that its placeholder produces a bad VoiceOver experience,
    which I will address separately.
    
    I removed the action to focus the stepper input when
    clicking the label as I believe connecting the label
    and input with an id is equivalent.
    
    This includes an override for ivy-codemirror’s codemirror
    dependency to take advantage of the screenReaderLabel
    configuration option in 5.53; thanks to @adityatoshniwal
    for that addition in codemirror/codemirror5#6197.
    backspace committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    a5c433e View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Fix button-name failures

    This rule is described here:
    https://dequeuniversity.com/rules/axe/3.5/button-name
    
    For the log streaming toggles, normally I would assert against
    conditionals like these, but I couldn’t find any assertions
    on the icons 😯
    backspace committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    cdbab70 View commit details
    Browse the repository at this point in the history
  2. Add targeted rule-disabling

    This turns off one rule for the job definition test, as the
    CodeMirror component is failing:
    https://dequeuniversity.com/rules/axe/3.5/scrollable-region-focusable
    backspace committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    4095504 View commit details
    Browse the repository at this point in the history