-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug
command archive content changes
#8462
Conversation
e0a80ec
to
c9cf971
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with minor tweaks.
Co-authored-by: Mahmood Ali <mahmood@hashicorp.com>
000c5bf
to
a7cb497
Compare
@@ -55,34 +59,83 @@ General Options: | |||
|
|||
Debug Options: | |||
|
|||
-duration=2m | |||
The duration of the log monitor command. Defaults to 2m. | |||
-duration=<interval> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be -duration=<duration>
instead of interval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! ugh. I'll include that change in the rename pr which I've just rebased on top of this. #8602
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
A set of usability improvements to nomad debug:
operator
endpointsstale
flag allows membership to be queried in stuck clustersIntervals are still numbered sequentially rather than by timestamp, with the rationale that timestamp precision gets a little awkward: either we use millisecond timestamps that are large, or second timestamps that duration settings can cause to be used more than once, or minimum durations. Open to suggestion!