debug command archive content changes
#8462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langmartin
force-pushed
the
f-nomad-debug-bits
branch
from
e0a80ec
to
c9cf971
Compare
Co-authored-by: Mahmood Ali <mahmood@hashicorp.com>
langmartin
force-pushed
the
f-nomad-debug-bits
branch
from
000c5bf
to
a7cb497
Compare
drewbailey
reviewed
Aug 11, 2020
| @@ -55,34 +59,83 @@ General Options: | |||
|
|
|||
| Debug Options: | |||
|
|
|||
| -duration=2m | |||
| The duration of the log monitor command. Defaults to 2m. | |||
| -duration=<interval> | |||
There was a problem hiding this comment.
should this be -duration=<duration> instead of interval
There was a problem hiding this comment.
yes! ugh. I'll include that change in the rename pr which I've just rebased on top of this. #8602
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of usability improvements to nomad debug:
operatorendpointsstaleflag allows membership to be queried in stuck clustersIntervals are still numbered sequentially rather than by timestamp, with the rationale that timestamp precision gets a little awkward: either we use millisecond timestamps that are large, or second timestamps that duration settings can cause to be used more than once, or minimum durations. Open to suggestion!