Commits on Jul 28, 2020

1. vault: expired tokens count toward batch limit …

   As of 0.11.3 Vault token revocation and purging was done in batches.
   However the batch size was only limited by the number of *non-expired*
   tokens being revoked.
   
   Due to bugs prior to 0.11.3, *expired* tokens were not properly purged.
   Long-lived clusters could have thousands to *millions* of very old
   expired tokens that never got purged from the state store.
   
   Since these expired tokens did not count against the batch limit, very
   large batches could be created and overwhelm servers.
   
   This commit ensures expired tokens count toward the batch limit with
   this one line change:
   
   ```
   - if len(revoking) >= toRevoke {
   + if len(revoking)+len(ttlExpired) >= toRevoke {
   ```
   
   However, this code was difficult to test due to being in a periodically
   executing loop. Most of the changes are to make this one line change
   testable and test it.

   

   schmichael committed Jul 28, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 4a14604
   • Browse repository at this point

   Copy the full SHA

   4a14604 View commit details

   Browse the repository at this point in the history