csi: add unpublish RPC #8572
Merged
csi: add unpublish RPC #8572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
f-csi-unpublish-rpc
branch
from
08cd243
to
3f9d65e
Compare
This was referenced Jul 31, 2020
langmartin
approved these changes
Aug 6, 2020
| @@ -448,9 +450,10 @@ func (v *CSIVolume) controllerPublishVolume(req *structs.CSIVolumeClaimRequest, | |||
| // Nomad's ID for the node) | |||
| targetCSIInfo, ok := targetNode.CSINodePlugins[plug.ID] | |||
| if !ok { | |||
| return fmt.Errorf("Failed to find NodeInfo for node: %s", targetNode.ID) | |||
| return fmt.Errorf("failed to find storage provider info for client %q, node plugin %q is not running or has not fingerprinted on this client", targetNode.ID, plug.ID) | |||
This changeset is plumbing for a `nomad volume detach` command that will be reused by the volumewatcher claim GC as well.
tgross
force-pushed
the
f-csi-unpublish-rpc
branch
from
3f9d65e
to
b86c25a
Compare
This was referenced Aug 7, 2020
Closed
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a fix for #8080, #8100, #8232 as summarized in #8232 (comment). Will help mitigate #8285, #8145, #8057. (2 of 4 PRs)
This changeset is plumbing for a
nomad volume detachcommand that will be reused by the volumewatcher claim GC as well.