Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csi: missing plugins during node delete are not an error #8619

Merged
merged 1 commit into from
Aug 10, 2020
Merged

csi: missing plugins during node delete are not an error #8619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion nomad/state/state_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,7 +1158,9 @@ func deleteNodeCSIPlugins(txn *memdb.Txn, node *structs.Node, index uint64) erro
return fmt.Errorf("csi_plugins lookup error %s: %v", id, err)
}
if raw == nil {
return fmt.Errorf("csi_plugins missing plugin %s", id)
// plugin may have been deregistered but we didn't
// update the fingerprint yet
continue
}

plug := raw.(*structs.CSIPlugin).Copy()
Expand Down