CSI RPC Token #8626
Merged
CSI RPC Token #8626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
reviewed
Aug 10, 2020
langmartin
force-pushed
the
b-csi-rpc-token
branch
from
00aa5e4
to
0951e8d
Compare
langmartin
force-pushed
the
b-csi-rpc-token
branch
from
0951e8d
to
057a096
Compare
tgross
added a commit
that referenced
this pull request
Oct 9, 2020
This item was completed in #8626
tgross
added a commit
that referenced
this pull request
Oct 9, 2020
This item was completed in #8626
fredrikhgrelland
pushed a commit
to fredrikhgrelland/nomad
that referenced
this pull request
Oct 22, 2020
This item was completed in hashicorp#8626
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSI Nodes call RPCs through the server that forward to other client nodes. They should do so with an authorization token that's permitted to execute those RPCs. This PR sends the
Node.SecretID, which when provided to the endpoints returns the nilaclObj. All namespace and policy ACL check funcs treat nil as the flag that ACLs are disabled. The ACL checker returns an error if ACLs are active and an appropriate token isn't provided.The other alternative is to thread the user token through from job submission. I believe that the
Node.SecretIDis correct since the job could not have been allocated without user permissions at the time of submission, and we don't want an errorUnpublishinga volume belonging to a job that was started with an expired or revoked token.Fixes #8373