Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failed core jobs should not have follow-ups #8682

Merged
merged 2 commits into from
Aug 18, 2020
Merged

failed core jobs should not have follow-ups #8682

merged 2 commits into from
Aug 18, 2020

Commits on Aug 17, 2020

  1. failed core jobs should not have follow-ups 

    If a core job fails more than the delivery limit, the leader will create a new
eval with the TriggeredBy field set to `failed-follow-up`.

Evaluations for core jobs have the leader's ACL, which is not valid on another
leader after an election. The `failed-follow-up` evals do not have ACLs, so
core job evals that fail more than the delivery limit or core job evals that
span leader elections will never succeed and will be re-enqueued forever. So
we should not retry with a `failed-follow-up`.
    @tgross
    tgross committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    5895555 View commit details
    Browse the repository at this point in the history

  2. don't emit follow-up eval for core jobs

    @tgross
    tgross committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    025a613 View commit details
    Browse the repository at this point in the history