Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect alloc job version for lost/failed allocs #8691

Merged
merged 5 commits into from
Aug 25, 2020

Commits on Aug 19, 2020

  1. Respect alloc job version for lost/failed allocs

    This change fixes a bug where lost/failed allocations are replaced by
    allocations with the latest versions, even if the version hasn't been
    promoted yet.
    
    Now, when generating a plan for lost/failed allocations, the scheduler
    first checks if the current deployment is in Canary stage, and if so, it
    ensures that any lost/failed allocations is replaced one with the latest
    promoted version instead.
    Mahmood Ali committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    5720266 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. Have Plan.AppendAlloc accept the job

    Mahmood Ali committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    cb038b1 View commit details
    Browse the repository at this point in the history
  2. tweak stack job manipulation

    To address review comments
    Mahmood Ali committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    92bb372 View commit details
    Browse the repository at this point in the history
  3. simplify canary check

    `(alloc.DeploymentStatus == nil || !alloc.DeploymentStatus.IsCanary())`
    and `!alloc.DeploymentStatus.IsCanary()` are equivalent.
    Mahmood Ali committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    3a28b85 View commit details
    Browse the repository at this point in the history
  4. Update scheduler/reconcile.go

    Co-authored-by: Chris Baker <1675087+cgbaker@users.noreply.github.com>
    Mahmood Ali and cgbaker committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    f075bcc View commit details
    Browse the repository at this point in the history