-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: panic introduced by #8453 #8834
Conversation
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @greut! Thanks for this fix!
It looks like from the test-nomad
CI job that there's a test failure introduced in TestJobEndpoint_Register_Vault_MultiNamespaces
.
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
@tgross I overlooked the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @greut!
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
…le error introduced by hashicorp#8834
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
if
err
is nil, then doingerr.Error()
triggers a panic.