Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: Revert requireCanary logic #8867

Merged
merged 2 commits into from
Sep 15, 2020
Merged

scheduler: Revert requireCanary logic #8867

merged 2 commits into from
Sep 15, 2020

Commits on Sep 10, 2020

  1. test for rescheduling non-canaries

    Mahmood Ali committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    2bb78ac View commit details
    Browse the repository at this point in the history

  2. Revert the requireCanary check introduced in https://github.com/has… 

    …hicorp/nomad/pull/8691/files#diff-1801138ac4d10f2064ba6f2e434ac9b4L430-R431 .

The change was intended to fix a case where a canary alloc may fail to
be rescheduled if all the other allocs fail as well (e.g. if all allocs
happen to be placed on a node that died).  However, it introduced some
unintended side-effects.

Reverting the change for now and will investigate further.
    Mahmood Ali committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    64175dc View commit details
    Browse the repository at this point in the history