Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul/connect: validate group network on expose port injection #8882

Merged
merged 1 commit into from
Sep 14, 2020

Commits on Sep 14, 2020

  1. consul/connect: validate group network on expose port injection

    In #7800, Nomad would automatically generate a port label for service
    checks making use of the expose feature, if the port was not already
    set. This change assumed the group network would be correctly defined
    (as is checked in a validation hook later). If the group network was
    not definied, a panic would occur on job submisssion. This change
    re-uses the group network validation helper to make sure the network
    is correctly definied before adding ports to it.
    
    Fixes #8875
    shoenig committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    5c3f631 View commit details
    Browse the repository at this point in the history