Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/docker/driver.go: change default signal for docker driver to SIGTERM? #8933

Merged
merged 1 commit into from
Sep 29, 2020
Merged

drivers/docker/driver.go: change default signal for docker driver to SIGTERM? #8933

merged 1 commit into from
Sep 29, 2020

Conversation

jf
Copy link
Contributor

@jf jf commented Sep 19, 2020 •
edited by shoenig

Partial #8932 (needs docs)

NOTE: I'm guessing ideally, the standard messaging in various places (nomad/structs/structs.go, command/alloc_status.go) with text like 'Sent interrupt' might have to change as well, but maybe that can be part of a bigger discussion. For now, I think updating the default from SIGINT to SIGTERM makes sense.

References: https://www.nomadproject.io/docs/job-specification/task#kill_signal, https://docs.docker.com/engine/reference/commandline/stop/

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 19, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@shoenig shoenig self-requested a review September 22, 2020 16:05
@shoenig shoenig mentioned this pull request Sep 29, 2020
Closed
@shoenig shoenig merged commit d714783 into hashicorp:master Sep 29, 2020
shoenig added a commit that referenced this pull request Oct 2, 2020
@shoenig
docs: document docker signal fix, add tests
a123080 
This PR adds a version specific upgrade note about the docker stop
signal behavior. Also adds test for the signal logic in docker driver.

Closes #8932 which was fixed in #8933
shoenig added a commit that referenced this pull request Oct 2, 2020
@shoenig
docs: document docker signal fix, add tests
a299b76 
This PR adds a version specific upgrade note about the docker stop
signal behavior. Also adds test for the signal logic in docker driver.

Closes #8932 which was fixed in #8933
@shoenig shoenig mentioned this pull request Oct 2, 2020
Merged
roaks3 pushed a commit that referenced this pull request Oct 7, 2020
@shoenig @roaks3
docs: document docker signal fix, add tests
7175035 
This PR adds a version specific upgrade note about the docker stop
signal behavior. Also adds test for the signal logic in docker driver.

Closes #8932 which was fixed in #8933
fredrikhgrelland pushed a commit to fredrikhgrelland/nomad that referenced this pull request Oct 22, 2020
@shoenig @fredrikhgrelland
docs: document docker signal fix, add tests
ce99d8c 
This PR adds a version specific upgrade note about the docker stop
signal behavior. Also adds test for the signal logic in docker driver.

Closes hashicorp#8932 which was fixed in hashicorp#8933
@jazzyfresh jazzyfresh mentioned this pull request Dec 2, 2020
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoenig shoenig shoenig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jf @hashicorp-cla @shoenig