Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events/api #8947

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Events/api #8947

merged 1 commit into from
Sep 28, 2020

Conversation

drewbailey
Copy link
Contributor

@drewbailey drewbailey commented Sep 22, 2020 •
edited

Adds a new /v1/events/stream/ endpoint and corresponding RPC for streaming events to a client.

This endpoint introduces a new streaming mechanism for sending ndjson (http://ndjson.org/) for event streaming. This approach was chosen over our current stream framer since fragmenting event data in a framed envelope with offset wasn't necessary for the UI, and made consumption for regular consumers difficult.

The ndjson streamer will send events as new line delimited JSON and send an empty heartbeat({}) every 5 seconds.

ACL checking is too restrictive right now (requires a management token), in a follow up PR it will be updated to check ACL policies against requested Topics.

@drewbailey drewbailey force-pushed the events/api branch 3 times, most recently from fd9181c to 24aa54e Compare September 25, 2020 18:05
@drewbailey drewbailey marked this pull request as ready for review September 25, 2020 18:05
@drewbailey drewbailey force-pushed the events/api branch 2 times, most recently from 05f6a87 to b0cb956 Compare September 25, 2020 20:36
@drewbailey drewbailey force-pushed the events/api branch 3 times, most recently from be1a6fc to 00e7838 Compare September 28, 2020 13:40
@drewbailey
Event Stream API/RPC
31079ca 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
@drewbailey drewbailey merged commit d7b63a9 into event-stream Sep 28, 2020
@drewbailey drewbailey deleted the events/api branch September 28, 2020 14:13
drewbailey added a commit that referenced this pull request Sep 29, 2020
@drewbailey
Event Stream API/RPC (#8947)
7f6f1ad 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
drewbailey added a commit that referenced this pull request Sep 29, 2020
@drewbailey
Event Stream API/RPC (#8947)
655ee4b 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
drewbailey added a commit that referenced this pull request Oct 1, 2020
@drewbailey
Event Stream API/RPC (#8947)
54b4581 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
drewbailey added a commit that referenced this pull request Oct 2, 2020
@drewbailey
Event Stream API/RPC (#8947)
c1ab00c 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
drewbailey added a commit that referenced this pull request Oct 5, 2020
@drewbailey
Event Stream API/RPC (#8947)
3ebbc68 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
drewbailey added a commit that referenced this pull request Oct 6, 2020
@drewbailey
Event Stream API/RPC (#8947)
542441e 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
drewbailey added a commit that referenced this pull request Oct 7, 2020
@drewbailey
Event Stream API/RPC (#8947)
bd1e7c5 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
drewbailey added a commit that referenced this pull request Oct 8, 2020
@drewbailey
Event Stream API/RPC (#8947)
19ba709 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
drewbailey added a commit that referenced this pull request Oct 8, 2020
@drewbailey
Event Stream API/RPC (#8947)
0d2ebe1 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
drewbailey added a commit that referenced this pull request Oct 9, 2020
@drewbailey
Event Stream API/RPC (#8947)
2176adc 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
drewbailey added a commit that referenced this pull request Oct 12, 2020
@drewbailey
Event Stream API/RPC (#8947)
d748cb4 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
drewbailey added a commit that referenced this pull request Oct 12, 2020
@drewbailey
Event Stream API/RPC (#8947)
2205ce2 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
drewbailey added a commit that referenced this pull request Oct 13, 2020
@drewbailey
Event Stream API/RPC (#8947)
ff7fc0f 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
drewbailey added a commit that referenced this pull request Oct 14, 2020
@drewbailey
Event Stream API/RPC (#8947)
b825ba3 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
fredrikhgrelland pushed a commit to fredrikhgrelland/nomad that referenced this pull request Oct 22, 2020
@drewbailey @fredrikhgrelland
Event Stream API/RPC (hashicorp#8947)
9c5090a 
This Commit adds an /v1/events/stream endpoint to stream events from.

The stream framer has been updated to include a SendFull method which
does not fragment the data between multiple frames. This essentially
treats the stream framer as a envelope to adhere to the stream framer
interface in the UI.

If the `encode` query parameter is omitted events will be streamed as
newline delimted JSON.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoenig shoenig Awaiting requested review from shoenig

@schmichael schmichael Awaiting requested review from schmichael

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@drewbailey