Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update consul-template to v0.25.1 #8988

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

fredrikhgrelland
Copy link
Contributor

While working on #8849 I needed consul namespace support in consul-template.

Inclusive language changes required some refactoring, but is kept backwards compatible.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fredrikhgrelland! Thanks so much for this PR, especially for pulling out the consul-template change from the large PR you're working on.


This isn't a blocker but would help testing: to test backwards compatibility, I ran a job on a build from master, then built this PR and restarted Nomad. Unfortunately I got a panic when restarting Nomad with the new build (see below). If I wipe out the data dir and run with this build, it works fine. And when I rebased this PR on master the problem and started over from scratch the problem went away... there's probably something that landed on master that you don't have in your branch that's breaking raft entries, so if you were to rebase from master that would make it easier to test this out. Thanks!

Started Nomad.
==> WARNING: Bootstrap mode enabled! Potentially unsafe operation.
==> Loaded configuration from /etc/nomad.d/standalone.hcl
==> Starting Nomad agent...
panic: failed to apply request: []byte{0x48, 0x81, 0xaa, 0x43, 0x72, 0x65, 0x61, 0x74, 0x65, 0x54, 0x69, 0x6d, 0x65, 0xd3, 0x16, 0x39, 0xdd, 0xcf, 0x8d, 0x5b, 0xd7, 0xf9}
goroutine 16 [running]:
github.com/hashicorp/nomad/nomad.(*nomadFSM).Apply(0xc0002d73b0, 0xc0005d0aa0, 0x4f8ad20, 0xbfd590b12b50cc03)
        github.com/hashicorp/nomad/nomad/fsm.go:292 +0x193b
github.com/hashicorp/raft.(*Raft).runFSM.func1(0xc00007cac0)
        github.com/hashicorp/raft@v1.1.3-0.20200211192230-365023de17e6/fsm.go:90 +0x2c1
github.com/hashicorp/raft.(*Raft).runFSM.func2(0xc000212000, 0x33, 0x40)
        github.com/hashicorp/raft@v1.1.3-0.20200211192230-365023de17e6/fsm.go:113 +0x75
github.com/hashicorp/raft.(*Raft).runFSM(0xc0005f4000)
        github.com/hashicorp/raft@v1.1.3-0.20200211192230-365023de17e6/fsm.go:219 +0x42f
github.com/hashicorp/raft.(*raftState).goFunc.func1(0xc0005f4000, 0xc0003d6c00)
        github.com/hashicorp/raft@v1.1.3-0.20200211192230-365023de17e6/state.go:146 +0x55
created by github.com/hashicorp/raft.(*raftState).goFunc
        github.com/hashicorp/raft@v1.1.3-0.20200211192230-365023de17e6/state.go:144 +0x66

command/agent/config.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
fredrikhgrelland pushed a commit to fredrikhgrelland/nomad that referenced this pull request Oct 1, 2020
@fredrikhgrelland
Copy link
Contributor Author

Rebased from master and ready for review.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked out the rebase PR and tested it out and everything looks great! 👍

@tgross tgross merged commit 8238b9f into hashicorp:master Oct 1, 2020
@fredrikhgrelland fredrikhgrelland deleted the consul_template_0251 branch October 1, 2020 18:32
@tgross tgross added this to the 0.13 milestone Oct 2, 2020
roaks3 pushed a commit that referenced this pull request Oct 7, 2020
fredrikhgrelland added a commit to fredrikhgrelland/nomad that referenced this pull request Oct 22, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants