Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: move tests to use NewMockUi func. #9027

Merged
merged 1 commit into from
Oct 6, 2020
Merged

cli: move tests to use NewMockUi func. #9027

merged 1 commit into from
Oct 6, 2020

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Oct 5, 2020

closes #9026

@jrasell jrasell added type/enhancement theme/testing Test related issues labels Oct 5, 2020
@jrasell jrasell self-assigned this Oct 5, 2020
cgbaker
cgbaker approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrasell jrasell merged commit 87bfe0e into master Oct 6, 2020
@jrasell jrasell deleted the f-gh-9026 branch October 6, 2020 06:28
@jrasell jrasell mentioned this pull request Oct 6, 2020
Merged
davemay99 added a commit that referenced this pull request Oct 6, 2020
@davemay99
update deprecated syntax per GH-9027
e0e3a01
fredrikhgrelland pushed a commit to fredrikhgrelland/nomad that referenced this pull request Oct 22, 2020
@davemay99 @fredrikhgrelland
update deprecated syntax per hashicorpGH-9027
9b90f5a
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

@cgbaker cgbaker cgbaker approved these changes

@notnoop notnoop Awaiting requested review from notnoop

Assignees

@jrasell jrasell

Labels
theme/testing Test related issues type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli: tests use new(cli.MockUi) which is strongly discouraged within lib
3 participants
@jrasell @tgross @cgbaker