-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: CSI mount_options are available only for filesystem vols #9043
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hashicorp/nomad/b6rv9nv9h |
Converting this back to draft while we hash out some of these issues in #9021 (comment), because this might not be the right approach. |
The CSI specifcation allows only the `file-system` attachment mode to have mount options. The `block-device` mode is left "intentionally empty, for now" in the protocol. We should be validating against this problem, but our documentation also had it backwards.
8285371
to
8554b45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question about mount_options; otherwise, preview checks out.
…corp#9043) The CSI specification allows only the `file-system` attachment mode to have mount options. The `block-device` mode is left "intentionally empty, for now" in the protocol. We should be validating against this problem, but our documentation also had it backwards. Also adds missing mount_options on group volume.
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Partial fix for #9021
The CSI specifcation allows only the
file-system
attachment mode to havemount options. The
block-device
mode is left "intentionally empty, for now"in the protocol. We should be validating against this problem, but our
documentation also had it backwards.
Also adds missing docs for
mount_options
on the group'svolume
spec.Fixing the validation is in #9044