Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: CSI mount_options are available only for filesystem vols #9043

Merged
merged 3 commits into from
Oct 8, 2020
Merged

docs: CSI mount_options are available only for filesystem vols #9043

merged 3 commits into from
Oct 8, 2020

Conversation

tgross
Copy link
Member

@tgross tgross commented Oct 7, 2020 •
edited

Partial fix for #9021

The CSI specifcation allows only the file-system attachment mode to have
mount options. The block-device mode is left "intentionally empty, for now"
in the protocol. We should be validating against this problem, but our
documentation also had it backwards.

Also adds missing docs for mount_options on the group's volume spec.

Fixing the validation is in #9044

@vercel
Copy link

vercel bot commented Oct 7, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hashicorp/nomad/b6rv9nv9h
✅ Preview: https://nomad-git-docs-volume-mount-options.hashicorp.vercel.app

@tgross tgross requested review from cgbaker and lgfa29 October 7, 2020 15:39
@tgross tgross added this to the 0.13 milestone Oct 7, 2020
@tgross tgross mentioned this pull request Oct 7, 2020
Closed
@tgross tgross marked this pull request as draft October 7, 2020 18:15
@tgross
Copy link
Member Author

tgross commented Oct 7, 2020

Converting this back to draft while we hash out some of these issues in #9021 (comment), because this might not be the right approach.

@tgross
docs: CSI mount_options are available only for filesystem vols
8554b45 
The CSI specifcation allows only the `file-system` attachment mode to have
mount options. The `block-device` mode is left "intentionally empty, for now"
in the protocol. We should be validating against this problem, but our
documentation also had it backwards.
@tgross tgross marked this pull request as ready for review October 7, 2020 20:47
@tgross tgross requested review from notnoop and shoenig October 7, 2020 20:49
cgbaker
cgbaker approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question about mount_options; otherwise, preview checks out.

website/pages/docs/commands/volume/register.mdx Outdated Show resolved Hide resolved
website/pages/docs/commands/volume/register.mdx Outdated Show resolved Hide resolved
@tgross tgross merged commit 9d1efd5 into master Oct 8, 2020
@tgross tgross deleted the docs-volume-mount-options branch October 8, 2020 12:49
fredrikhgrelland pushed a commit to fredrikhgrelland/nomad that referenced this pull request Oct 22, 2020
@tgross @fredrikhgrelland
docs: CSI mount_options are available only for filesystem vols (hashi…
e93b979 
…corp#9043)

The CSI specification allows only the `file-system` attachment mode to have
mount options. The `block-device` mode is left "intentionally empty, for now"
in the protocol. We should be validating against this problem, but our
documentation also had it backwards.

Also adds missing mount_options on group volume.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@notnoop notnoop notnoop approved these changes

@cgbaker cgbaker cgbaker approved these changes

@shoenig shoenig Awaiting requested review from shoenig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tgross @notnoop @cgbaker