Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csi: loosen ValidateVolumeCapability requirements #9049

Merged
merged 3 commits into from
Oct 8, 2020
Merged

csi: loosen ValidateVolumeCapability requirements #9049

merged 3 commits into from
Oct 8, 2020

Commits on Oct 8, 2020

  1. csi: loosen ValidateVolumeCapability requirements 

    The CSI specification for `ValidateVolumeCapability` says that we shall
"reconcile successful capability-validation responses by comparing the
validated capabilities with those that it had originally requested" but leaves
the details of that reconcilation unspecified. This API is not implemented in
Kubernetes, so controller plugins don't have a real-world implementation to
verify their behavior against.

We have found that CSI plugins in the wild may return "successful" but
incomplete `VolumeCapability` responses, so we can't require that all
capabilities we expect have been validated, only that the ones that have been
validated match. This appears to violate the CSI specification but until
that's been resolved in upstream we have to loosen our validation
requirements. The tradeoff is that we're more likely to have runtime errors
during `NodeStageVolume` instead of at the time of volume registration.
    @tgross
    tgross committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    ebff972 View commit details
    Browse the repository at this point in the history

  2. fix mispellings

    @tgross
    tgross committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    d3136e1 View commit details
    Browse the repository at this point in the history

  3. add changelog entry

    @tgross
    tgross committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    848cd1e View commit details
    Browse the repository at this point in the history