Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Topology Visualization #9077

Merged
merged 52 commits into from
Oct 15, 2020
Merged

UI: Topology Visualization #9077

merged 52 commits into from
Oct 15, 2020

Commits on Oct 15, 2020

  1. Scaffold a new topology page

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    753bfbf View commit details
    Browse the repository at this point in the history

  2. Small cluster example scenario for the topo viz

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    1e9e2a1 View commit details
    Browse the repository at this point in the history

  3. Scaffold topo viz components

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    6d9f59f View commit details
    Browse the repository at this point in the history

  4. Add ember modifiers addon

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    b6867ef View commit details
    Browse the repository at this point in the history

  5. Quick window resize modifier

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    a003a8a View commit details
    Browse the repository at this point in the history

  6. Prototype of the topo viz 

    - Plot all datacenters
- For each datacenter, plot all nodes
- For each node, plot all allocations by memory and cpu
- For empty nodes, highlight the emptiness
- When hovering over allocations, give them visual focus
    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    773404a View commit details
    Browse the repository at this point in the history

  7. Fix factory bug that made it so pending allocs had no resources

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    7cf3b74 View commit details
    Browse the repository at this point in the history

  8. Start click interaction for topo viz allocs

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    b3ddd1f View commit details
    Browse the repository at this point in the history

  9. Tweak topo scenario

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    606910f View commit details
    Browse the repository at this point in the history

  10. Fleshing out the first prototype of the topology visualization

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    36df145 View commit details
    Browse the repository at this point in the history

  11. Touch up topo viz interactions

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    0b3a78b View commit details
    Browse the repository at this point in the history

  12. Add cluster details to the topology page

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    c2b7f7c View commit details
    Browse the repository at this point in the history

  13. Super rough allocation details, needs some style love

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    f5c3d0e View commit details
    Browse the repository at this point in the history

  14. Associate sibling allocations by drawing lines

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    f56f631 View commit details
    Browse the repository at this point in the history

  15. Guard against undefined denominators

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    290f7d8 View commit details
    Browse the repository at this point in the history

  16. Updated alloc and cluster details on topo page

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    3cd464d View commit details
    Browse the repository at this point in the history

  17. Medium scale topo scenario

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    98dd258 View commit details
    Browse the repository at this point in the history

  18. CSS Grid based masonry layout 

    TBH, it's buggy and I don't like it.
    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    2704c3e View commit details
    Browse the repository at this point in the history

  19. Add more variety to the node heights

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    e9626ce View commit details
    Browse the repository at this point in the history

  20. Make the alloc select render path more efficient by not needlessly re… 

    …computing data
    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    9991dc6 View commit details
    Browse the repository at this point in the history

  21. Refactor topo viz to do as much computation upfront & use faster data… 

    … structures

Now all data loading happens in the TopoViz component as well as
computation of resource proportions.

Allocation selection state is also managed centrally uses a dedicated
structure indexed by group key (job id and task group name). This way
allocations don't need to be scanned at the node level, which is O(n) at
the best (assuming no ember overhead on recomputes).
    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    d13c065 View commit details
    Browse the repository at this point in the history

  22. Connect the memory and cpu rectangles

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    37cc9b7 View commit details
    Browse the repository at this point in the history

  23. A better loading screen for the topo viz while nodes load

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    be2d0fc View commit details
    Browse the repository at this point in the history

  24. Second attempt at a masonry layout

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    a9e2917 View commit details
    Browse the repository at this point in the history

  25. New FlexMasonry component implements a masonry layout using flexbox

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    c152ccb View commit details
    Browse the repository at this point in the history

  26. Apply FlexMasonry to the TopoViz component

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    c5e8474 View commit details
    Browse the repository at this point in the history

  27. Conditionally use the FlexMasonry layout for datacenters within TopoViz

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    4e81ab8 View commit details
    Browse the repository at this point in the history

  28. Make the topo viz denser when there are >50 nodes 

    By hiding node details and making nodes interactive instead, we can pack
more allocations on a screen.
    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    f5f964b View commit details
    Browse the repository at this point in the history

  29. Fix a re-render bug with flexmasonry

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    a4c8ce4 View commit details
    Browse the repository at this point in the history

  30. Improved curves for allocation associations

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    bb68a14 View commit details
    Browse the repository at this point in the history

  31. Label empty clients in the topo viz chart

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    de9124e View commit details
    Browse the repository at this point in the history

  32. Add icons to denote draining or ineligibility of clients

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    927343f View commit details
    Browse the repository at this point in the history

  33. Filter total alloc count by only scheduled allocs

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    90dbab1 View commit details
    Browse the repository at this point in the history

  34. More information about clients in the info panel

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    639b3ff View commit details
    Browse the repository at this point in the history

  35. FlexMasonry integration tests

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    611b0b3 View commit details
    Browse the repository at this point in the history

  36. Test coverage for TopoViz::Node

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    84f88ec View commit details
    Browse the repository at this point in the history

  37. Migrate to the new resources properties for allocs and nodes

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    faaf697 View commit details
    Browse the repository at this point in the history

  38. Update topo viz code to use new alloc/node resources pattern

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    b185d09 View commit details
    Browse the repository at this point in the history

  39. Unit test for for GiB in format-bytes

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    334f72c View commit details
    Browse the repository at this point in the history

  40. Adjust topo viz controller to new resource code

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    f9dccf9 View commit details
    Browse the repository at this point in the history

  41. Update scenarios to use new resources code

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    a5ea84d View commit details
    Browse the repository at this point in the history

  42. Remove temp reloading of nodes in the TopoViz component

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    9390d24 View commit details
    Browse the repository at this point in the history

  43. Test coverage for TopoViz::Datacenter

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    3a48dbf View commit details
    Browse the repository at this point in the history

  44. Unit and integration tests for TopoViz component

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    13415df View commit details
    Browse the repository at this point in the history

  45. Some light topology acceptance tests

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    b5809d4 View commit details
    Browse the repository at this point in the history

  46. Treat legend term pairs as single wrapping elements

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    229fa29 View commit details
    Browse the repository at this point in the history

  47. Reset the standard environment values

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    e540312 View commit details
    Browse the repository at this point in the history

  48. Describe the glimmer-factory better including the motive

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    223011e View commit details
    Browse the repository at this point in the history

  49. Remove the scenarios I didn't need/didn't get to

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    2cf4b5d View commit details
    Browse the repository at this point in the history

  50. Factor out the common sum aggregator used in the topology controller

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    0d920ae View commit details
    Browse the repository at this point in the history

  51. Work around Safari's lack of text transform support

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    214ce4a View commit details
    Browse the repository at this point in the history

  52. Typo

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    8f94a98 View commit details
    Browse the repository at this point in the history